Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide operator when describe pod with empty value tolerations #47380

Merged
merged 1 commit into from
Jun 22, 2017
Merged

hide operator when describe pod with empty value tolerations #47380

merged 1 commit into from
Jun 22, 2017

Conversation

kevin-wangzefeng
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng commented Jun 12, 2017 •
edited

What this PR does / why we need it:
The tolerations printing in kubectl descirbe pod is not correct when toleration.value is empty, this PR is to fix it.

Before:

Tolerations:	node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s
		node.alpha.kubernetes.io/unreachable=:Exists:NoExecute for 300s

After:

Tolerations:	node.alpha.kubernetes.io/notReady:NoExecute for 300s
		node.alpha.kubernetes.io/unreachable:NoExecute for 300s

Also updated tests to cover all possible cases of describing pod with tolerations. See changes in of TestDescribePodTolerations() in describe_test.go

Which issue this PR fixes:

Special notes for your reviewer:

Release note:

NONE

@kevin-wangzefeng kevin-wangzefeng added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jun 12, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 12, 2017
@dims
Copy link
Member

dims commented Jun 13, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017
@kevin-wangzefeng
Copy link
Member Author

@fabianofranz Can you take a look at this? Need one more approve, thanks.

@kevin-wangzefeng
Copy link
Member Author

/cc @kubernetes/sig-cli-maintainers

@fabianofranz
Copy link
Contributor

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, fabianofranz, kevin-wangzefeng

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2017
@kevin-wangzefeng
Copy link
Member Author

@davidopp can we have this in 1.7?
/cc @kubernetes/sig-scheduling-bugs

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/bug Categorizes issue or PR as related to a bug. labels Jun 21, 2017
@timothysc timothysc added this to the v1.7 milestone Jun 22, 2017
@timothysc
Copy link
Member

@kevin-wangzefeng technically it should have an issue against it at this stage of the game now.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a896881 into kubernetes:master Jun 22, 2017
@kevin-wangzefeng
Copy link
Member Author

@timothysc Thanks, I will submit an issue first next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@fabianofranz fabianofranz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kevin-wangzefeng @dims @fabianofranz @k8s-github-robot @timothysc @k8s-ci-robot